[Minor] Clean up DecimalArray API Usage #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ballista
datafusion
alamb
force-pushed
the
alamb/cleanup_decimal_array
branch
from
9e4f672
to
c0a4784
Compare
|
I will review this tomorrow later. |
houqp
approved these changes
Mar 6, 2022
alamb
changed the title
Thanks for your refactor. @alamb |
Thank you @liukun4515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as it builds on #1851Which issue does this PR close?
N/A
Rationale for this change
Use a faster (less bounds checking) and more idiomatic API for creating
DecimalArraymostly so that when others are looking for examples of how to createDecimalArrays they find one of these rather thanDecimalBuilderWhat changes are included in this PR?
Cleans up some
DecimalArraycreation using APIs added in apache/arrow-rs#1223I didn't spend any time cleaning up binary.rs as I believe @liukun4515 has plans for that
Are there any user-facing changes?