Add SQL query planner support for Scalar Subqueries #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
force-pushed
the
sql-planner-scalar-subquery
branch
from
c82e410
to
d082305
Compare
alamb
approved these changes
Apr 27, 2022
| input_schema: &DFSchema, | ||
| ) -> Result<Expr> { | ||
| Ok(Expr::ScalarSubquery(Subquery { | ||
| subquery: Arc::new(self.subquery_to_plan(subquery.clone(), input_schema)?), |
There was a problem hiding this comment.
So the scalar subquery must produce a single row typically otherwise it is a runtime error
Do you have thoughts about in what stage a query like the following would throw an error?
"SELECT p.id, (SELECT id FROM person) FROM person p"
There was a problem hiding this comment.
I was thinking that an optimizer rule should perform this type of validation check and this would cover both the SQL and DataFrame API (and maybe substrait one day) use cases.
There was a problem hiding this comment.
I filed #2361 to track the validation work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2353
Rationale for this change
Add SQL query planner support for Scalar Subqueries
What changes are included in this PR?
Add SQL query planner support for Scalar Subqueries
Are there any user-facing changes?
Add SQL query planner support for Scalar Subqueries