Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "IS TRUE/FALSE" syntax (redo) #3235

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

sarahyurick
Copy link
Contributor

Which issue does this PR close?

Closes #3159

What changes are included in this PR?

Redo of #3189 with the IsNotDistinctFrom operator instead, from @alamb's suggestion. Includes SQL-level tests as well.

Since IS TRUE and IS FALSE should only work on boolean and null datatypes, we are waiting on #3222 so that we can add type validation.

@github-actions github-actions bot added core Core DataFusion crate sql SQL Planner labels Aug 23, 2022
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @sarahyurick

@codecov-commenter
Copy link

Codecov Report

Merging #3235 (79759f1) into master (74872a3) will increase coverage by 0.02%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master    #3235      +/-   ##
==========================================
+ Coverage   85.81%   85.84%   +0.02%     
==========================================
  Files         292      293       +1     
  Lines       53117    53206      +89     
==========================================
+ Hits        45585    45675      +90     
+ Misses       7532     7531       -1     
Impacted Files Coverage Δ
datafusion/expr/src/logical_plan/plan.rs 78.90% <50.00%> (+0.89%) ⬆️
datafusion/optimizer/tests/integration-test.rs 84.00% <84.00%> (ø)
datafusion/core/tests/sql/expr.rs 99.85% <100.00%> (+<0.01%) ⬆️
datafusion/sql/src/planner.rs 80.52% <100.00%> (+0.07%) ⬆️
datafusion/core/src/physical_plan/metrics/value.rs 86.93% <0.00%> (-0.51%) ⬇️
datafusion/expr/src/window_frame.rs 93.27% <0.00%> (+0.84%) ⬆️
datafusion/expr/src/utils.rs 91.10% <0.00%> (+1.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andygrove andygrove merged commit c11f303 into apache:master Aug 24, 2022
@ursabot
Copy link

ursabot commented Aug 24, 2022

Benchmark runs are scheduled for baseline = aa6a34b and contender = c11f303. c11f303 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "IS TRUE/FALSE" syntax
4 participants