-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set versions to dependencies with path in benchmarks Cargo.toml file #4136
Set versions to dependencies with path in benchmarks Cargo.toml file #4136
Conversation
env_logger = "0.9" | ||
futures = "0.3" | ||
mimalloc = { version = "0.1", optional = true, default-features = false } | ||
num_cpus = "1.13.0" | ||
object_store = "0.5.0" | ||
parquet = "26.0.0" | ||
parquet-test-utils = { path = "../parquet-test-utils/" } | ||
parquet-test-utils = { path = "../parquet-test-utils/", version = "0.1.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another issue is that we don't publish parquet-test-utils
so we still can't publish this crate. This dependency is used in the parquet_filter_pushdown
benchmark and not in tpch
. I wonder if we should consider re-organizing these benchmarks into individual crates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree there is some sort of impedance mismatch with the benchmarks at the moment (like are they something we ever want to run outside a source checkout) 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ArkashaJavelin
env_logger = "0.9" | ||
futures = "0.3" | ||
mimalloc = { version = "0.1", optional = true, default-features = false } | ||
num_cpus = "1.13.0" | ||
object_store = "0.5.0" | ||
parquet = "26.0.0" | ||
parquet-test-utils = { path = "../parquet-test-utils/" } | ||
parquet-test-utils = { path = "../parquet-test-utils/", version = "0.1.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree there is some sort of impedance mismatch with the benchmarks at the moment (like are they something we ever want to run outside a source checkout) 🤔
Benchmark runs are scheduled for baseline = 2a834d1 and contender = 18c6a0b. 18c6a0b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #4134
Rationale for this change
See #4134
Are these changes tested?
Are there any user-facing changes?