Minor: pass ParquetFileMetrics to build_row_filter in parquet
#4161
Conversation
| @@ -414,8 +414,7 @@ impl FileOpener for ParquetOpener { | |||
| table_schema.as_ref(), | |||
| builder.metadata(), | |||
| reorder_predicates, | |||
| &file_metrics.pushdown_rows_filtered, | |||
| &file_metrics.pushdown_eval_time, | |||
| &file_metrics, | |||
There was a problem hiding this comment.
it was just bothering me for some reason that this was different than prune_row_groups and build_page_filter
There was a problem hiding this comment.
Keep align is necessary. Will keep in mind in future.
There was a problem hiding this comment.
(to be clear I was the one who wrote the original code that was not consistent -- so I need to keep it in mind :) )
|
Benchmark runs are scheduled for baseline = da76feb and contender = 30813dc. 30813dc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
re #3463
Rationale for this change
Continue a somewhat OCD quest to get the parquet code to be internally consistent in structure
What changes are included in this PR?
Change arguments to an internal function to match other modules
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
No.