minor: add another test case to cover join ambiguous check #4305
Conversation
| \n TableScan: person\ | ||
| \n SubqueryAlias: p2\ | ||
| \n TableScan: person"; | ||
| quick_test(sql, expected); |
There was a problem hiding this comment.
Except for typo, LGTM.
Thanks for adding the test case.
| @@ -6057,7 +6057,7 @@ mod tests { | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_ambiguous_coulmn_referece_in_join() { | |||
| fn test_ambiguous_coulmn_referece_in_on_join() { | |||
There was a problem hiding this comment.
Should be column references
| } | ||
|
|
||
| #[test] | ||
| fn test_ambiguous_coulmn_referece_with_in_using_join() { |
|
Thanks for your review @mingmwang, I will fix it. |
There was a problem hiding this comment.
Thanks @ygf11 and @mingmwang
I am merging this PR in to reduce the review queue -- I'll make a minor PR to fix the typos shortly
|
Benchmark runs are scheduled for baseline = 55bf8e9 and contender = 03f85f1. 03f85f1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?