minor: make plan_from_tables return one plan instead of Vec
#4336
Conversation
| @@ -1020,45 +1013,39 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { | |||
| } | |||
|
|
|||
| // process `from` clause | |||
| let plans = self.plan_from_tables(select.from, ctes, outer_query_schema)?; | |||
| let empty_from = matches!(plans.first(), Some(LogicalPlan::EmptyRelation(_))); | |||
| let plan = self.plan_from_tables(select.from, ctes, outer_query_schema)?; | |||
There was a problem hiding this comment.
this is a nice refactor -- thank you @jackwener
alamb
changed the title
plan_from_tables return one plan instead of Vecplan_from_tables return one plan instead of Vec to cleanup the cdoe
alamb
changed the title
plan_from_tables return one plan instead of Vec to cleanup the cdoeplan_from_tables return one plan instead of Vec
|
Benchmark runs are scheduled for baseline = 03f85f1 and contender = 72a4487. 72a4487 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
make plan_from_tables return just one plan
Rationale for this change
make code simpler
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?