Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log error if page index can not be evaluated #4358

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 24, 2022

Which issue does this PR close?

Closes #4236 (cc @HaoYang670 )

Rationale for this change

errors are ignored when creating page indexes but were being logged as error (to the output)

What changes are included in this PR?

reduce logging level to debug from error

Are these changes tested?

No (for logging)

Are there any user-facing changes?

Not really. cc @Ted-Jiang

@github-actions github-actions bot added the core Core DataFusion crate label Nov 24, 2022
@HaoYang670
Copy link
Contributor

Thank you, @alamb !
I am OK with the change. But I re-ran the test filter_pushdown::single_file on the master branch and there is no error reported now. Not sure if this has been fixed by #4255.

@Ted-Jiang
Copy link
Member

@alamb this change to good to me! But i still have a question about when to use error! in datafusion 🤔? after d7a7fb6 merged i think there should no error log in test.

@alamb alamb changed the title Do not log error if page index can not be evaluatied Do not log error if page index can not be evaluated Nov 25, 2022
@alamb
Copy link
Contributor Author

alamb commented Nov 26, 2022

@alamb this change to good to me! But i still have a question about when to use error! in datafusion 🤔?

I like the "I generally subscribe to the following convention:" answer from this;
https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels

So only log errors when there is something a system adminstrator should look at / look into. If they can't do anything about it it probably shouldn't be an error (more like a warn! if it means a DataFusion bug or debug if more like an FYI)

after d7a7fb6 merged i think there should no error log in test.

Awesome!

@alamb
Copy link
Contributor Author

alamb commented Nov 26, 2022

I think this is a reasonable change even though the specific error in datafusion was previously fixed is this PR will reduce the level of errors people see in their logs

@alamb alamb merged commit 120689c into apache:master Nov 26, 2022
@alamb alamb deleted the alamb/no_error_in_page branch November 26, 2022 12:58
@ursabot
Copy link

ursabot commented Nov 26, 2022

Benchmark runs are scheduled for baseline = 24453f9 and contender = 120689c. 120689c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo test reports errors on the master branch.
4 participants