Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOLLOWUP: remove optimize() #4619

Merged
merged 1 commit into from
Dec 15, 2022
Merged

FOLLOWUP: remove optimize() #4619

merged 1 commit into from
Dec 15, 2022

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Dec 14, 2022 •
edited by alamb
Loading

Which issue does this PR close?

Related to #4619

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules labels Dec 14, 2022
@jackwener jackwener changed the title FOLLOWUP: remove optimize FOLLOWUP: remove optimize() Dec 14, 2022
@jackwener jackwener mentioned this pull request Dec 14, 2022
Merged
@alamb alamb mentioned this pull request Dec 14, 2022
Closed
@alamb
Copy link
Contributor

alamb commented Dec 14, 2022

This PR appears to have many conflicts 🤔

Screenshot 2022-12-14 at 3 29 14 PM

@jackwener
Copy link
Member Author

jackwener commented Dec 14, 2022 •
edited
Loading

It's a little strange so many conflict. When I fix conflict, just exist 2 file conflict.😂
Have fixed conflict.

tustvold
tustvold approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the high-probability of further merge conflicts, I'm going to get this one in

@tustvold tustvold merged commit 2466877 into apache:master Dec 15, 2022
@jackwener jackwener deleted the remove_optimize branch December 15, 2022 12:40
@ursabot
Copy link

ursabot commented Dec 15, 2022

Benchmark runs are scheduled for baseline = 5c558e9 and contender = 2466877. 2466877 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Dec 15, 2022

🎉

@alamb
Copy link
Contributor

alamb commented Dec 15, 2022

It's a little strange so many conflict. When I fix conflict, just exist 2 file conflict.😂

Github's UI is quite strange sometimes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackwener @alamb @ursabot @tustvold