Fix the potential bug of check_all_column_from_schema #5287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The
check_all_column_from_schema
is used to check if columns are all in the schema.It is based on
index_of_column
. Giving the column,index_of_column
has three result:1
and3
will return Error. Incheck_all_column_from_schema
, we need distinguish these two, but currently we don't do it. This pr will fix it.What changes are included in this PR?
index_of_column_by_name
to returnResult<Option<usize>>
.is_column_from_schema
, andcheck_all_column_from_schema
calls it.Are these changes tested?
Yes
Are there any user-facing changes?