Minor: intersect expressions optimization #5388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization of the function "intersect".
During the execution of the function "extract_possible_join_keys", if the operator of an expression equals OR, then the algorithm goes recursively in depth of the tree and joins keys in the array "accum". As bottom nodes are majority and they may not have right and left descendants, then the join does not happen. However, "intersect" in any cases iterates over all left join keys, which is costly.
This minor patch fixed the problem.
Are these changes tested?
No new tests added
Are there any user-facing changes?
No