Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: intersect expressions optimization #5388

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Minor: intersect expressions optimization #5388

merged 1 commit into from
Feb 24, 2023

Conversation

izveigor
Copy link
Contributor

Optimization of the function "intersect".

During the execution of the function "extract_possible_join_keys", if the operator of an expression equals OR, then the algorithm goes recursively in depth of the tree and joins keys in the array "accum". As bottom nodes are majority and they may not have right and left descendants, then the join does not happen. However, "intersect" in any cases iterates over all left join keys, which is costly.

This minor patch fixed the problem.

Are these changes tested?

No new tests added

Are there any user-facing changes?

No

@github-actions github-actions bot added the optimizer Optimizer rules label Feb 24, 2023
Copy link
Contributor

@avantgardnerio avantgardnerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I question if this actually improves performance given cache pipelines and branch prediction misses, but I doubt it will hurt either.

@avantgardnerio avantgardnerio merged commit 7224901 into apache:main Feb 24, 2023
@ursabot
Copy link

ursabot commented Feb 24, 2023

Benchmark runs are scheduled for baseline = d64076b and contender = 7224901. 7224901 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants