Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove more projection. #5402

Merged
merged 1 commit into from
Feb 25, 2023
Merged

enhance: remove more projection. #5402

merged 1 commit into from
Feb 25, 2023

Conversation

jackwener
Copy link
Member

@jackwener jackwener commented Feb 25, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

enhance #5366 and fix its bors problem

What changes are included in this PR?

  • remove more projection.
  • fix main problem

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules labels Feb 25, 2023
@jackwener jackwener merged commit 38185ca into apache:main Feb 25, 2023
@jackwener
Copy link
Member Author

jackwener commented Feb 25, 2023

quick merge to fix main problem

@jackwener jackwener deleted the fix branch February 25, 2023 21:10
@ursabot
Copy link

ursabot commented Feb 25, 2023

Benchmark runs are scheduled for baseline = 0b77ec2 and contender = 38185ca. 38185ca is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Feb 26, 2023

This PR fixed a logical merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants