Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return schema of ExtensionPlan instead of its children's #5514

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Mar 8, 2023

Which issue does this PR close?

Related to #5513, but not close it as there is another unfinished discussion.

Rationale for this change

#5236 returns chindren's schema rather than ExtensionPlan's in all_schema, which will break other places that make use of ExtensionPlan.

What changes are included in this PR?

Correct all_schema's behavior

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Mar 8, 2023
@jackwener
Copy link
Member

Make great sense to me, thanks @waynexia .

Can you add a test to cover this case? thanks again.

Signed-off-by: Ruihang Xia <[email protected]>
@waynexia
Copy link
Member Author

waynexia commented Mar 9, 2023

Make great sense to me, thanks @waynexia .

Can you add a test to cover this case? thanks again.

Appreciate your suggestion! I add a UT for this change, but only covers the ExtensionPlan branch 🥲

@jackwener
Copy link
Member

Make great sense to me, thanks @waynexia .
Can you add a test to cover this case? thanks again.

Appreciate your suggestion! I add a UT for this change, but only covers the ExtensionPlan branch 🥲

I think we can add an extra integration-test to cover this case, look like unit test isn't enough.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is an improvement and has test coverage. I agree with @jackwener we can probably improve the coverage but I also think we can do so in a follow on PR

@alamb
Copy link
Contributor

alamb commented Mar 9, 2023

Thanks @waynexia

@alamb alamb merged commit 6a8c4a6 into apache:main Mar 9, 2023
@ursabot
Copy link

ursabot commented Mar 9, 2023

Benchmark runs are scheduled for baseline = 55c7c4d and contender = 6a8c4a6. 6a8c4a6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@andygrove andygrove added the bug Something isn't working label Mar 12, 2023
@waynexia waynexia deleted the fix-all-schema branch August 9, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants