Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

excluding doctests for mac/win64 platform ,Make them consistent with amd64 #5730

Merged
merged 1 commit into from
Mar 27, 2023
Merged

excluding doctests for mac/win64 platform ,Make them consistent with amd64 #5730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,11 +248,11 @@ jobs:
rustup toolchain install stable
rustup default stable
rustup component add rustfmt
- name: Run tests
- name: Run tests (excluding doctests)
shell: bash
run: |
export PATH=$PATH:$HOME/d/protoc/bin
cargo test
cargo test --lib --tests --bins --features avro,jit,scheduler,json,dictionary_expressions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a reasonable idea to run with the same features on mac and windows. Thank you @jiangzhx

env:
# do not produce debug symbols to keep memory usage down
RUSTFLAGS: "-C debuginfo=0"
Expand Down Expand Up @@ -282,10 +282,10 @@ jobs:
rustup toolchain install stable
rustup default stable
rustup component add rustfmt
- name: Run tests
- name: Run tests (excluding doctests)
shell: bash
run: |
cargo test
cargo test --lib --tests --bins --features avro,jit,scheduler,json,dictionary_expressions
env:
# do not produce debug symbols to keep memory usage down
RUSTFLAGS: "-C debuginfo=0"
Expand Down