Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: port select tests to sqllogictests #5740

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 25, 2023

Which issue does this PR close?

Part of #4495

Rationale for this change

Seee #4495

What changes are included in this PR?

Port some tests to sqllogictests

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Mar 25, 2023
@yjshen
Copy link
Member

yjshen commented Mar 26, 2023

Is it possible to debug these tests in the IDE by adding breakpoints after migrating them to sqllogictests? Apologies for the potentially silly question.

@Dandandan Dandandan merged commit 621b81a into apache:main Mar 27, 2023
@alamb
Copy link
Contributor Author

alamb commented Mar 27, 2023

Is it possible to debug these tests in the IDE by adding breakpoints after migrating them to sqllogictests? Apologies for the potentially silly question.

I don't know @yjshen

One thing you can do is to locally make a new test.slt file with just the query you are interested in perhaps 🤔

@alamb alamb deleted the alamb/port_select branch March 27, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants