Add assert on hash children partition count #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duongcongtoai
changed the title
duongcongtoai
force-pushed
the
validate-join-inputs
branch
from
37a8b07
to
7a08cbb
Compare
alamb
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Thanks @duongcongtoai -- this is a great idea. It looks like there is a conflict that needs to be resolved, but otherwise this looks great
| if self.mode == PartitionMode::Partitioned | ||
| && self.left.output_partitioning() != self.right.output_partitioning() | ||
| { | ||
| return Err(DataFusionError::Plan(format!( |
There was a problem hiding this comment.
This is likely caused by some sort of code error, so an internal error may make more sense
Suggested change
| return Err(DataFusionError::Plan(format!( | |
| return Err(DataFusionError::Internal(format!( |
There was a problem hiding this comment.
The same comment applies to the code below as well
duongcongtoai
force-pushed
the
validate-join-inputs
branch
from
b6b7653
to
bae8335
Compare
alamb
approved these changes
Apr 4, 2023
|
Test is failing, i'll check |
|
I took the liberty to push a fix for the clippy CI failure: https://github.com/apache/arrow-datafusion/actions/runs/4622652579/jobs/8194716556 to your branch in a29658b I also merged up from main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5738
Rationale for this change
Adding a small validation for join executors to prevent user from providing children inputs having different partition count, causing unexpected behavior
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?