Incorrect row comparison for tpch queries in benchmarks #5784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
commented
Mar 29, 2023
| @@ -1106,7 +1106,7 @@ mod ci { | |||
| let actual_row = &actual_vec[i]; | |||
| assert_eq!(expected_row.len(), actual_row.len()); | |||
|
|
|||
| for j in 0..expected.len() { | |||
There was a problem hiding this comment.
e.g., If expected contains only one record batch, we only compare first column between rows.
There was a problem hiding this comment.
Not sure if any existing tests will fail by this.
viirya
commented
Mar 30, 2023
benchmarks/src/bin/tpch.rs
Outdated
Comment on lines
1121
to
1134
| ( | ||
| ScalarValue::Decimal128(Some(l), _, s), | ||
| ScalarValue::Decimal128(Some(r), _, _), | ||
| ) => { | ||
| let tolerance = 0.1; | ||
| if ((l - r) as f64 / 10_i32.pow(*s as u32) as f64).abs() | ||
| > tolerance | ||
| { | ||
| panic!( | ||
| "Expected: {}; Actual: {}; Tolerance: {}", | ||
| l, r, tolerance | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
This is necessary to pass ci::verify_q9 after this change. There is a slight (0.01) difference.
alamb
approved these changes
Mar 30, 2023
benchmarks/src/bin/tpch.rs
Outdated
| ScalarValue::Decimal128(Some(l), _, s), | ||
| ScalarValue::Decimal128(Some(r), _, _), | ||
| ) => { | ||
| let tolerance = 0.1; |
There was a problem hiding this comment.
tolerance is already defined above in the float path -- maybe we could make it a constant or something. Very minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5783.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?