Poll next open file future while scanning current file #5800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkharderdev
approved these changes
Mar 31, 2023
Co-authored-by: Dan Harris <[email protected]>
Co-authored-by: Dan Harris <[email protected]>
fsdvh
pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Apr 21, 2023
* Poll next open file future while scanning current file * Update datafusion/core/src/physical_plan/file_format/file_stream.rs Co-authored-by: Dan Harris <[email protected]> * Update datafusion/core/src/physical_plan/file_format/file_stream.rs Co-authored-by: Dan Harris <[email protected]> * Update file_stream.rs --------- Co-authored-by: Dan Harris <[email protected]> (cherry picked from commit 4d0c9fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5799.
What changes are included in this PR?
Next file opening future will now be polled while the current file is being scanned.
Are these changes tested?
I did not add any new tests as I believe this change should be covered by existing tests, but I am happy to add additional tests that I didn't think of.
Are there any user-facing changes?
I believe not.