Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Port some timestamp tests to sqllogictests #5804

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 30, 2023

Which issue does this PR close?

Part of #4495

Rationale for this change

  1. https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests#sqllogictests
  2. I would like to evaluate timestamp coverage in one place

What changes are included in this PR?

Port some tests over

Are these changes tested?

Yes

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of DataFusion label Mar 30, 2023
@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) and removed development-process Related to development process of DataFusion labels Mar 30, 2023
@alamb alamb force-pushed the alamb/port_timestamp_tests branch from fc92bff to 4acfd89 Compare March 30, 2023 21:35
@alamb
Copy link
Contributor Author

alamb commented Mar 31, 2023

Thank you for the review @yjshen and @r4ntix

@alamb alamb merged commit 75588fe into apache:main Mar 31, 2023
@alamb alamb deleted the alamb/port_timestamp_tests branch July 26, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants