Port math.rs to sqllogictest #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
2010YOUY01
force-pushed
the
port_sqltest
branch
from
2f7b1b2
to
30afbbf
Compare
jiangzhx
approved these changes
Apr 18, 2023
r4ntix
approved these changes
Apr 18, 2023
comphead
reviewed
Apr 18, 2023
| @@ -87,3 +87,24 @@ query RRRRRRRR | |||
| SELECT round(125.2345, -3), round(125.2345, -2), round(125.2345, -1), round(125.2345), round(125.2345, 0), round(125.2345, 1), round(125.2345, 2), round(125.2345, 3) | |||
| ---- | |||
| 0 100 130 125 125 125.2 125.23 125.235 | |||
|
|
|||
| # Create table for atan2 test | |||
| statement ok | |||
There was a problem hiding this comment.
its good to drop table after the test completed, or as alternative you can prepare data in WITH clause.
There was a problem hiding this comment.
Thank you for the feedback, I think even creating a table is not necessary. Updated
comphead
reviewed
Apr 18, 2023
| @@ -87,3 +87,9 @@ query RRRRRRRR | |||
| SELECT round(125.2345, -3), round(125.2345, -2), round(125.2345, -1), round(125.2345), round(125.2345, 0), round(125.2345, 1), round(125.2345, 2), round(125.2345, 3) | |||
| ---- | |||
| 0 100 130 125 125 125.2 125.23 125.235 | |||
|
|
|||
| # atan2 | |||
| query RRRR | |||
There was a problem hiding this comment.
please include also tests with nulls. Its likely gap from prev implementation
atan2(null, 1.0), atan2(2.0, null)
There was a problem hiding this comment.
Sure, expression tests for null cases can also be found here, returning NULL seems to be expected
comphead
approved these changes
Apr 18, 2023
|
LGTM 👍 |
|
Thank you @2010YOUY01 and everyone who reviewed this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4495.
Rationale for this change
Ported tests in math.rs into sqllogictest.
The engine for sqllogictest will round big decimals to 12 digits, so the output of test cases is also round to 12 digits.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?