Parallelise collect_partitioned #6109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Apr 24, 2023
| })? | ||
| }); | ||
|
|
||
| futures::future::try_join_all(handles).await |
There was a problem hiding this comment.
Using try_join_all will abort on first error as opposed to join_all which would run the execution to completion, and then discard everything but the first error if any
alamb
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Looks reasonable to me -- cc @metesynnada this I think is related to #6049
|
Thank you @tustvold |
Dandandan
approved these changes
Apr 25, 2023
Dandandan
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This makes it consistent with RepartitionExec and CoalescePartitionsExec
What changes are included in this PR?
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?