Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for object_store builders of datafusion-cli #6576

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

r4ntix
Copy link
Contributor

@r4ntix r4ntix commented Jun 7, 2023

Which issue does this PR close?

Closes #6574

Rationale for this change

Related PR: #5732, apache/arrow-rs#4021

What changes are included in this PR?

Add tests for object_store builders: get_s3_object_store_builder, get_oss_object_store_builder, get_gcs_object_store_builder

Are these changes tested?

Yes

Are there any user-facing changes?

None

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @r4ntix

@alamb alamb merged commit 25b6556 into apache:main Jun 7, 2023
@r4ntix r4ntix deleted the issue-6574 branch June 12, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for object_store builder of datafusion-cli
2 participants