Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract GroupValues (#6969) #7016

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Extract GroupValues (#6969) #7016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a961ad0
Extract GroupValues (#6969)
tustvold Jul 19, 2023
ad3a4aa
Merge remote-tracking branch 'upstream/main' into extract-group-values
tustvold Jul 19, 2023
ab2db82
Merge remote-tracking branch 'upstream/main' into extract-group-values
tustvold Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/core/src/physical_plan/aggregates/order/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ impl GroupOrdering {
}

/// remove the first n groups from the internal state, shifting
/// all existing indexes down by `n`. Returns stored hash values
/// all existing indexes down by `n`
pub fn remove_groups(&mut self, n: usize) {
match self {
GroupOrdering::None => {}
Expand Down
Loading