Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace array_has/array_has_all/array_has_any macro to remove duplicate code #8263

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

Veeupup
Copy link
Contributor

@Veeupup Veeupup commented Nov 18, 2023

Which issue does this PR close?

fix array_has/array_has_all/array_has_any in #7988

datafusion-cli binary size seems to decrease by about 60~KB

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Physical Expressions label Nov 18, 2023
@Veeupup Veeupup changed the title Replace array_has/array_has_all/array_has_any macro to reomve duplicate code Replace array_has/array_has_all/array_has_any macro to remove duplicate code Nov 18, 2023
@Veeupup
Copy link
Contributor Author

Veeupup commented Nov 19, 2023

@alamb @jayzhan211 ready for review, thanks! : )

@alamb
Copy link
Contributor

alamb commented Nov 20, 2023

Thanks @Veeupup and @jayzhan211 -- I'll try and review this PR today

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @Veeupup and @jayzhan211 🙏

@alamb alamb merged commit f310db3 into apache:main Nov 20, 2023
24 checks passed
@Veeupup Veeupup deleted the array_has branch November 21, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants