Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projection Pushdown over StreamingTableExec #8299

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Projection Pushdown over StreamingTableExec #8299

merged 2 commits into from
Nov 27, 2023

Conversation

berkaysynnada
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

ProjectionExec with its input StreamingTableExec can be merged into a single StreamingTableExec, provided there is no evaluation or aliasing in ProjectionExec.

What changes are included in this PR?

projection_pushdown rule for physical plans is extended with StreamingTableExec.

Are these changes tested?

Yes.

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Nov 22, 2023
Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the code and LGTM

@ozankabak
Copy link
Contributor

I will go ahead and merge this. If there is anything we missed, let us know and we will promptly address with a follow-on PR.

@ozankabak ozankabak merged commit d81c961 into apache:main Nov 27, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants