Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid concat for array_replace #8337

Merged
merged 6 commits into from
Dec 2, 2023
Merged

Conversation

jayzhan211
Copy link
Contributor

@jayzhan211 jayzhan211 commented Nov 28, 2023

Which issue does this PR close?

Follow on #8137

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Result in benchmark

n = 1e8
previous 2.0442s, this PR 1.6569s

Signed-off-by: jayzhan211 <[email protected]>
@github-actions github-actions bot added physical-expr Physical Expressions core Core DataFusion crate labels Nov 28, 2023
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
@jayzhan211 jayzhan211 marked this pull request as ready for review November 28, 2023 13:47
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work @jayzhan211 👏

@Dandandan Dandandan merged commit 340ecfd into apache:main Dec 2, 2023
22 checks passed
@Dandandan
Copy link
Contributor

Thanks @jayzhan211

appletreeisyellow pushed a commit to appletreeisyellow/datafusion that referenced this pull request Dec 14, 2023
* add benchmark

Signed-off-by: jayzhan211 <[email protected]>

* fmt

Signed-off-by: jayzhan211 <[email protected]>

* address clippy

Signed-off-by: jayzhan211 <[email protected]>

* cleanup

Signed-off-by: jayzhan211 <[email protected]>

* fix comment

Signed-off-by: jayzhan211 <[email protected]>

---------

Signed-off-by: jayzhan211 <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants