Minor: Make it easier to work with Expr::ScalarFunction #8350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
alamb
commented
Nov 28, 2023
| @@ -362,6 +362,13 @@ pub struct ScalarFunction { | |||
| pub args: Vec<Expr>, | |||
| } | |||
|
|
|||
| impl ScalarFunction { | |||
| // return the Function's name | |||
| pub fn name(&self) -> &str { | |||
There was a problem hiding this comment.
The point of the PR is to add this
alamb
commented
Nov 28, 2023
| @@ -1219,8 +1226,8 @@ impl fmt::Display for Expr { | |||
| write!(f, " NULLS LAST") | |||
| } | |||
| } | |||
| Expr::ScalarFunction(ScalarFunction { func_def, args }) => { | |||
| fmt_function(f, func_def.name(), false, args, true) | |||
| Expr::ScalarFunction(fun) => { | |||
There was a problem hiding this comment.
Doing so I think makes code like this easier / less inceptionish (Expr::ScalarFunction vs expr::ScalarFunction 🤯 )
universalmind303
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
great small improvement. I was actually going to open up an issue to expose the name as a method. I'm currently working on an unrelated PR that is manually mapping the variants to the names, but this'll make it much easier & cleaner.
tustvold
approved these changes
Nov 29, 2023
|
Thanks @universalmind303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #8258
Rationale for this change
While integrating the change from #8258 downstream in IOx, I found it would have been very helpful to have
fun.name()available and I think it makes the code more consiseWhat changes are included in this PR?
Add
expr::ScalarFunction::name()Are these changes tested?
Existing tests
Are there any user-facing changes?