Add alias check to optimize projections merge #8438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
mustafasrepo
changed the title
haohuaijin
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Thanks @mustafasrepo , LGTM!
I also check the output column name, it's correct
❯ create table t(x bigint, y bigint) as values (1,2), (1,3);
0 rows in set. Query took 0.016 seconds.
❯ select z+1, y from (select x+1 as z, y from t) where y > 1;
+--------------+---+
| z + Int64(1) | y |
+--------------+---+
| 3 | 2 |
| 3 | 3 |
+--------------+---+
2 rows in set. Query took 0.009 seconds.
7 tasks
alamb
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Thank you @mustafasrepo and @haohuaijin
This looks good to me -- @jackwener do you have a moment to double check this as well?
jackwener
reviewed
Dec 7, 2023
jackwener
approved these changes
Dec 7, 2023
Co-authored-by: jakevin <[email protected]>
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Dec 15, 2023
* Relax schema check for optimize projections. * Minor changes * Update datafusion/optimizer/src/optimize_projections.rs Co-authored-by: jakevin <[email protected]> --------- Co-authored-by: jakevin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8432.
Rationale for this change
Currently,
optimize_projectionrule fails for the query in the issue. Because of schema difference before and after the rule.This PR fixes this bug. To see more rationale see [#8432]
What changes are included in this PR?
To not change schema, we add alias when name changes during merging
Are these changes tested?
Yes
Are there any user-facing changes?