fix: RANGE frame for corner cases with empty ORDER BY clause should be treated as constant sort #8445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e treated as constant sort
github-actions
bot
added
sql
viirya
commented
Dec 7, 2023
| // Note that this follows Postgres behavior. | ||
| // In these cases, we regularize the ORDER BY clause if the ORDER BY clause | ||
| // is absent. If an ORDER BY clause is present but has more than one column, | ||
| // the ORDER BY clause is unchanged. Note that this follows Postgres behavior. | ||
| if (frame.start_bound.is_unbounded() | ||
| || frame.start_bound == WindowFrameBound::CurrentRow) | ||
| && (frame.end_bound == WindowFrameBound::CurrentRow | ||
| || frame.end_bound.is_unbounded()) |
There was a problem hiding this comment.
RANGE frame with UNBOUNDED or CURRENT ROW PRECEDING/FOLLOWING without ORDER BY, all rows of the partitions become peers of the current row, i.e., the sort expression returns the same for all rows.
7 tasks
mustafasrepo
approved these changes
Dec 8, 2023
|
Thank you @mustafasrepo |
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Dec 15, 2023
…e treated as constant sort (apache#8445) * fix: RANGE frame for corner cases with empty ORDER BY clause should be treated as constant sort * fix * Make the test not flaky * fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
We currently regularize RANGE window frame with UNBOUNDED/CURRENT ROW bounds with empty ORDER BY clause to ROWS frame with the UNBOUNDED bounds. This produces inconsistent result compared to Postgres where the case is treated as ORDER BY with constant sort key and unchanged window frame.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?