Add partial serde support for ParquetWriterOptions #8627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
alamb
approved these changes
Dec 23, 2023
| } | ||
|
|
||
| message WriterProperties { | ||
| int32 data_page_size_limit = 1; |
There was a problem hiding this comment.
given the rust fields are usize, is there any reason to use in32 in the protobuf encoding?
Maybe it would make more sense to use i64 or u64 here instead 🤔
There was a problem hiding this comment.
Good point. I have updated to u32.
There was a problem hiding this comment.
Actually, I misread / misunderstood your comment. I changed to u32 on the basis that these should not need to support negative numbers, but I may need to research this more to make sure that is the case.
There was a problem hiding this comment.
Never mind, in Rust they are usize, so can't be negative.
There was a problem hiding this comment.
Now changed to u64 to better match usize.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8598
Closes #8619
There is a follow on issue #8632 to support advanced writer options, but this should be enough to unblock Ballista.
If this PR is accepted then I will create a similar PR to do the same for CSV.
Rationale for this change
Required by Ballista so that we can save query results to Parquet.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?