support LargeList in array_prepend and array_append
#8679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Weijun-H
commented
Dec 29, 2023
Comment on lines
-55
to
-70
| /// Downcasts multiple arguments into a single concrete type | ||
| /// $ARGS: &[ArrayRef] | ||
| /// $ARRAY_TYPE: type to downcast to | ||
| /// | ||
| /// $returns a Vec<$ARRAY_TYPE> | ||
| macro_rules! downcast_vec { | ||
| ($ARGS:expr, $ARRAY_TYPE:ident) => {{ | ||
| $ARGS | ||
| .iter() | ||
| .map(|e| match e.as_any().downcast_ref::<$ARRAY_TYPE>() { | ||
| Some(array) => Ok(array), | ||
| _ => internal_err!("failed to downcast"), | ||
| }) | ||
| }}; | ||
| } | ||
|
|
comphead
reviewed
Dec 29, 2023
Weijun-H
force-pushed
the
support-largelist-append-prepend
branch
from
5fc1910
to
24a0c11
Compare
add TODO comment for future tests
Weijun-H
force-pushed
the
support-largelist-append-prepend
branch
from
122d36f
to
2cbb397
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Parts #8185
Rationale for this change
What changes are included in this PR?
LargeListinarray_prependandarray_appendArrayAndElementAre these changes tested?
Are there any user-facing changes?