Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Fix flake in newly added dictionary.slt test #8769

Closed
wants to merge 1 commit into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 5, 2024

Which issue does this PR close?

Related to #8750

Rationale for this change

I added new tests in #8750

I noticed this test failed on main on one CI job and then passes on the next

Here is an example failure https://github.com/apache/arrow-datafusion/actions/runs/7426719857/job/20211097126

What changes are included in this PR?

Add rowsort to the output of a query without an order by to keep it consistent

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants