Minor: distinguish parquet row group pruning type in unit test #8921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ted-Jiang
changed the title
alamb
approved these changes
Jan 20, 2024
Comment on lines
+94
to
102
| test_row_group_prune( | ||
| Scenario::Timestamps, | ||
| "SELECT * FROM t where nanos < to_timestamp('2020-01-02 01:01:11Z')", | ||
| Some(0), | ||
| Some(1), | ||
| Some(0), | ||
| 10, | ||
| ) | ||
| .await; |
There was a problem hiding this comment.
There are so many parameters here it is getting hard to read the tests I think (as you have three different constants that need to be remembered)
Maybe we can (as a follow on PR) make a more self documenting, something like
Suggested change
| test_row_group_prune( | |
| Scenario::Timestamps, | |
| "SELECT * FROM t where nanos < to_timestamp('2020-01-02 01:01:11Z')", | |
| Some(0), | |
| Some(1), | |
| Some(0), | |
| 10, | |
| ) | |
| .await; | |
| RowGroupPruningTest::new() | |
| .with_scenario(Scenario::Timestamps) | |
| .with_query("SELECT * FROM t where nanos < to_timestamp('2020-01-02 01:01:11Z')"), | |
| .with_expected_errors(Some(0)), | |
| .with_pruned_by_stats(Some(1)), | |
| .with_pruned_by_bloom_filter(Some(0)), | |
| .with_expected_rows(10) | |
| ) | |
| .await; |
alamb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related #8880. when i implements 8880 cause lot ut fail, because not distinguish between parquet row group pruning by statistics or bloom filter
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?