Lead and Lag window functions should support default value with datatype other than Int64 #9001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type other than Int64
github-actions
bot
added
physical-expr
alamb
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Looks good to me -- thanks @viirya
cc @mustafasrepo and @comphead
| @@ -2364,6 +2364,16 @@ impl ScalarValue { | |||
| ScalarValue::try_from_array(&cast_arr, 0) | |||
| } | |||
|
|
|||
| /// Try to cast this value to a ScalarValue of type `data_type` | |||
9 tasks
mustafasrepo
approved these changes
Jan 26, 2024
|
Thanks! I think this is the fix to #8307, so you can use that issue number in the PR description. |
comphead
reviewed
Jan 26, 2024
| @@ -2364,6 +2364,16 @@ impl ScalarValue { | |||
| ScalarValue::try_from_array(&cast_arr, 0) | |||
| } | |||
|
|
|||
| /// Try to cast this value to a ScalarValue of type `data_type` | |||
| pub fn cast_to(&self, data_type: &DataType) -> Result<Self> { | |||
There was a problem hiding this comment.
I was introducing the same method to overcome unnecessary string conversion in separate PR 👍
|
Thank you @alamb @mustafasrepo @simonvandel @comphead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8307.
Rationale for this change
Noticed this when reviewing #8989. Currently we only support default value with Int64 data type for Lead and Lag window functions. This patch enables other data types to be used as default value.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?