[task #8201] Port tests in expr.rs to sqllogictest, finish the left c… #9014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…left cases Signed-off-by: tangruilin <[email protected]>
github-actions
bot
added
core
|
Amazing @Tangruilin -- thank you . I plan to review this later today or tomorrow |
This was referenced Jan 27, 2024
alamb
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
Thank you @Tangruilin -- this looks amazing 🏆 -- thank you for helping push #6195 over the 🏁 line ❤️
There are a few comments I think would be valuable to add here, but I will add them to your PR to help get this one ready.
Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ases
Which issue does this PR close?
Closes #8201 .
Closes #6195
Rationale for this change
What changes are included in this PR?
This PR move left tests in
expr.rsto expr.slt.Are these changes tested?
Yes. These changes are tests
Are there any user-facing changes?
No