Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document minimum required rust version #9071

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Document minimum required rust version #9071

merged 2 commits into from
Jan 30, 2024

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Updates the Rust version compatibility section to point to minimum supported Rust version exact value

Related to #8997

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@comphead comphead requested a review from alamb January 30, 2024 16:53
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 30, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @comphead

README.md Outdated
@@ -94,4 +94,4 @@ Optional features:

## Rust Version Compatibility

This crate is tested with the latest stable version of Rust. We do not currently test against other, older versions of the Rust compiler.
Datafusion crate is tested with the [minimum required stable Rust version](https://github.com/search?q=repo%3Aapache%2Farrow-datafusion+rust-version+language%3ATOML+path%3A%2F%5ECargo.toml%2F&type=code)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clever way to get the right correct place 👍

Screenshot 2024-01-30 at 3 11 16 PM

@comphead comphead merged commit 7fb83cc into apache:main Jan 30, 2024
3 checks passed
@comphead
Copy link
Contributor Author

Thanks @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants