Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for to_timestamp and make_date functions #9086

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

Omega359
Copy link
Contributor

Which issue does this PR close?

#9085

Related to pull #9040 it was noted in a comment that it would be good to have benchmarks around the functions to ascertain if they needed additional perf work or not.

What changes are included in this PR?

Perf tests.

Are these changes tested?

Yes

Are there any user-facing changes?

No.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @Omega359

@alamb alamb merged commit 0ca7f55 into apache:main Jan 31, 2024
22 checks passed
@alamb
Copy link
Contributor

alamb commented Jan 31, 2024

Filed #9089 and #9090 to optimize these functions

@Omega359 Omega359 deleted the feature/make_test_bench branch February 2, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants