Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove External Table Backwards Compatibility Options #9105

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

yyy1000
Copy link
Contributor

@yyy1000 yyy1000 commented Feb 2, 2024

Which issue does this PR close?

Closes #8547 .

Rationale for this change

See issue for details

What changes are included in this PR?

Options single_file, append_new_files and create_local_path are removed already. This is to remove the Backwards Compatibility so that providing these options will not work now.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Feb 2, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yyy1000 -- makes sense to me

cc @tustvold and @devinjdangelo

@alamb alamb merged commit e61c71d into apache:main Feb 5, 2024
22 checks passed
@alamb
Copy link
Contributor

alamb commented Feb 5, 2024

Thanks again @yyy1000

@yyy1000 yyy1000 deleted the remove_option branch February 5, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove External Table Backwards Compatibility Options
2 participants