Minor: improve Display of output ordering of StreamTableExec
#9225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
changed the title
StreamTableExec
alamb
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Thank you @mustafasrepo -- this looks like a great improvement to me 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
In other sources such as
CsvExec, when there is more than 1 valid ordering at the source; all orderings are displayed at the plan. For instance, ifCsvExecis ordered by[a ASC, b ASC], [c ASC]output ordering will be displayed asoutput_orderings=[[a@1 ASC NULLS LAST, b@2 ASC NULLS LAST], [c@3 ASC NULLS LAST].However, currently output ordering of the
StreamTableExecis displayed asoutput_ordering=[a@1 ASC NULLS LAST, b@2 ASC NULLS LAST]where only one of the valid orderings is displayed. This PR changes this behaviour to replicate behaviour of other sources.Are these changes tested?
Are there any user-facing changes?