Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: chore: improve catalog test in mod.rs #9244

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Feb 16, 2024

Which issue does this PR close?

There is no need to clone the schema in the memory_catalog_dereg_empty_schema test

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Feb 16, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caicancai -- looks like a nice improvement to me

@alamb alamb changed the title chore: improve catalog test in mod.rs Minor: chore: improve catalog test in mod.rs Feb 16, 2024
@alamb alamb merged commit e07a79c into apache:main Feb 16, 2024
24 checks passed
@caicancai caicancai deleted the clone branch February 17, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants