Uplift keys/dependencies to use more workspace inheritance #9293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
alamb
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
This makes sense to me -- thank you @Jefffrey
I wonder if there are any other tests we should run here to make sure it doesn't interfere with releases? @andygrove any thoughts?
Otherwise I think we should merge up from main and then this PR would be good to go.
9 tasks
alamb
approved these changes
Feb 28, 2024
| @@ -51,6 +51,11 @@ rust-version = "1.72" | |||
| version = "36.0.0" | |||
|
|
|||
| [workspace.dependencies] | |||
| # We turn off default-features for some dependencies here so the workspaces which inherit them can | |||
|
Thanks again @Jefffrey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Try use workspace inheritance more, for both regular package keys, and also dependencies
Note that due to rust-lang/cargo#11329 we need to specify
default-features = falsefor the workspace dependency then override todefault-features = truewhere we need, as the reverse does not work. If this isn't preferable we can revert back to the previous way of manually specifying these dependencies again without workspace inheritance.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?