Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc/health/v1/health.proto has a name conflict over grpc.health.v1.HealthCheckResponse #2394

Closed
HubQin opened this issue Aug 24, 2023 · 3 comments · Fixed by #2395
Closed

Comments

@HubQin
Copy link
Contributor

HubQin commented Aug 24, 2023

Environment

  • Server: Dubbo-go, v3.1.0
  • Client: Dubbo-go, v3.1.0
  • Protocol: Dubbo
  • Registry: Nacos

Issue description

health check in "dubbo.apache.org/dubbo-go/v3/protocol/dubbo3/health/triple_health_v1" conflicts with the one in "google.golang.org/grpc/health/grpc_health_v1".

Code to show the bug:

package main

import (
	_ "dubbo.apache.org/dubbo-go/v3/imports"
	_ "google.golang.org/grpc/health/grpc_health_v1"
)

func main() {

}

To execute the code above, it's necessary to create a go.mod file and update the dependencies.

Logs

Click me to check logs After running code above, panic occurs:
panic: proto: file "grpc/health/v1/health.proto" has a name conflict over grpc.health.v1.HealthCheckResponse
	previously from: "dubbo.apache.org/dubbo-go/v3/protocol/dubbo3/health/triple_health_v1"
	currently from:  "google.golang.org/grpc/health/grpc_health_v1"
See https://protobuf.dev/reference/go/faq#namespace-conflict

See doc in: https://protobuf.dev/reference/go/faq#namespace-conflict.
This issue arises due to the protocol/dubbo3/health/triple_health_v1/health.proto having an identical package name as https://github.com/grpc/grpc-proto/blob/master/grpc/health/v1/health.proto.

HubQin added a commit to HubQin/dubbo-go that referenced this issue Aug 24, 2023
…/grpc

health check in "dubbo.apache.org/dubbo-go/v3/protocol/dubbo3/health/triple_health_v1" conflicts with the one in "google.golang.org/grpc/health/grpc_health_v1".

Fixes apache#2394
justxuewei pushed a commit that referenced this issue Sep 5, 2023
…/grpc (#2395)

* fix: health.proto has name conflict with the one in google.golang.org/grpc

health check in "dubbo.apache.org/dubbo-go/v3/protocol/dubbo3/health/triple_health_v1" conflicts with the one in "google.golang.org/grpc/health/grpc_health_v1".

Fixes #2394

* update license
@majintao
Copy link

这个问题处理了,怎么不整个标签. 项目有google grpc 用go get -u dubbo.apache.org/dubbo-go/v3 基本是没办法解决

@limabing
Copy link

limabing commented Dec 1, 2023

问题没有解决啊, 怎么就关闭了?
main分支都还是存在这个问题。

@HubQin
Copy link
Contributor Author

HubQin commented Dec 11, 2023

我看了下,v3.1.1-rc1已经有这个commit。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants