Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solve config bool field zero value bug by using pointer #2344

Merged
merged 2 commits into from
Jul 1, 2023

Conversation

ev1lQuark
Copy link
Contributor

Apply #2338 to main branch.

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
52.2% 52.2% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #2344 (ce0c626) into main (95b463b) will increase coverage by 0.00%.
The diff coverage is 79.06%.

❗ Current head ce0c626 differs from pull request most recent head 9e000fa. Consider uploading reports for the commit 9e000fa to get more accurate results

@@           Coverage Diff           @@
##             main    #2344   +/-   ##
=======================================
  Coverage   44.10%   44.10%           
=======================================
  Files         294      295    +1     
  Lines       17890    17933   +43     
=======================================
+ Hits         7890     7909   +19     
- Misses       9161     9180   +19     
- Partials      839      844    +5     
Impacted Files Coverage Δ
cluster/router/tag/match.go 75.58% <0.00%> (-15.12%) ⬇️
config/provider_config.go 45.92% <ø> (ø)
config/tracing_config.go 66.66% <ø> (ø)
filter/metrics/filter.go 73.91% <0.00%> (-11.09%) ⬇️
protocol/dubbo3/dubbo3_invoker.go 58.33% <0.00%> (ø)
protocol/dubbo3/dubbo3_protocol.go 56.02% <0.00%> (ø)
cluster/router/tag/router.go 56.89% <50.00%> (-2.76%) ⬇️
metrics/prometheus/after_invocation.go 69.23% <71.42%> (-25.06%) ⬇️
metrics/prometheus/before_invocation.go 77.77% <77.77%> (ø)
metrics/prometheus/reporter.go 66.66% <80.00%> (+13.33%) ⬆️
... and 4 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit ff1e964 into apache:main Jul 1, 2023
@ev1lQuark ev1lQuark deleted the ptr branch July 4, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants