Nacos support subscribe to all with '*' #2374
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2374 +/- ##
==========================================
- Coverage 44.22% 44.11% -0.12%
==========================================
Files 305 304 -1
Lines 18628 18594 -34
==========================================
- Hits 8239 8202 -37
- Misses 9526 9531 +5
+ Partials 863 861 -2
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
| logger.Warnf("event listener game over.") | ||
| return perrors.New("nacosRegistry is not available.") | ||
| } | ||
| services, err := nr.getAllSubscribeServiceNames() |
There was a problem hiding this comment.
Do we need a scheduled pulling task here? What if the service name list in Nacos server changes after we subscribed to '', for example, if a new service name is registered, will we still get notified by subscribing to ''?
There was a problem hiding this comment.
This can be added later.
| logger.Warnf("event listener game over.") | ||
| return perrors.New("nacosRegistry is not available.") | ||
| } | ||
| services, err := nr.getAllSubscribeServiceNames() |
There was a problem hiding this comment.
This can be added later.
No description provided.