refactor protoc-gen-triple #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
protoc-gen-triple should adapt to protoc logic, i.e. protoc --go_out=gen --triple_out=gen path/to/file.proto. Maybe we could refer to https://github.com/protocolbuffers/protobuf-go/blob/6d0a5dbd95005b70501b4cc2c5124dab07a1f4a0/compiler/protogen/protogen.go#L52 and think about how to put the content generated by Generator into protogen Run procedure. |
DMwangnima
requested changes
Aug 15, 2023
|
LGTM |
AlexStocks
reviewed
Aug 16, 2023
| @@ -0,0 +1,202 @@ | |||
|
|
|||
AlexStocks
reviewed
Aug 16, 2023
| @@ -0,0 +1,19 @@ | |||
| module dubbo.apache.org/dubbo-go/v3/triple-tool | |||
|
|
|||
| go 1.20 | |||
There was a problem hiding this comment.
版本太高了，跟 dubbogo go.mod 中的 go version 保持一致
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the previous stitching method to template
The command part is yet to be developed