-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimize the integration of otel tracing #2387
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## main #2387 +/- ##
==========================================
- Coverage 45.00% 44.94% -0.07%
==========================================
Files 306 307 +1
Lines 18692 18752 +60
==========================================
+ Hits 8413 8428 +15
- Misses 9405 9445 +40
- Partials 874 879 +5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -66,6 +66,10 @@ import ( | |||
_ "dubbo.apache.org/dubbo-go/v3/metadata/service/remote" | |||
_ "dubbo.apache.org/dubbo-go/v3/metrics/app_info" | |||
_ "dubbo.apache.org/dubbo-go/v3/metrics/prometheus" | |||
_ "dubbo.apache.org/dubbo-go/v3/otel/trace/jaeger" | |||
_ "dubbo.apache.org/dubbo-go/v3/otel/trace/zipkin" | |||
//_ "dubbo.apache.org/dubbo-go/v3/otel/trace/otlp" // FIXME: otlp-grpc use grpc health check which has the namespace conflict with dubbo3 protocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be fixed by #2395
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Resolves #2386
Features:
Bugs: