triple test #2391
triple test #2391
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
The rest of these changes appear to be ide one-click changes. I would pull it back, make changes in the specified package, and then remove the unused code |
| // *http.Client! | ||
| var httpClient = examplePingServer.Client() | ||
|
|
||
| // By default, clients use the Connect protocol. Add triple.WithGRPC() or |
There was a problem hiding this comment.
By default, clients use the Triple protocol.
| examplePingServer.URL(), | ||
| ) | ||
| response := tri.NewResponse(&pingv1.PingResponse{}) | ||
| err := client.Ping( |
There was a problem hiding this comment.
if err := client.Ping... err != nil
There is no need to declare a var in the func scope when it would not be used anymore.
| validateExpectedError := func(t *testing.T, err error) { | ||
| t.Helper() | ||
| assert.NotNil(t, err) | ||
| var connectErr *triple.Error |
There was a problem hiding this comment.
var tripleErr *triple.Error
| ) | ||
| ctx := context.Background() | ||
| // unary | ||
| //err := client.Ping(ctx, triple.NewRequest(nil), triple.NewResponse(&pingv1.PingResponse{})) |
There was a problem hiding this comment.
Please think about this case.
| //assert.Nil(t, err) | ||
| text := strings.Repeat(".", 256) | ||
| msg := &pingv1.PingResponse{} | ||
| err1 := client.Ping(ctx, triple.NewRequest(&pingv1.PingRequest{Text: text}), triple.NewResponse(msg)) |
| res := NewResponse(pingv1.PingResponse{}) | ||
| assert.True(t, stream.Receive(res)) | ||
| first := fmt.Sprintf("%p", stream.Msg()) | ||
| res1 := NewResponse(pingv1.PingResponse{}) |
| func TestServerStreamForClient(t *testing.T) { | ||
| t.Parallel() | ||
| stream := &ServerStreamForClient{conn: &nopStreamingClientConn{}} | ||
| // Ensure that each call to Receive allocates a new message. This helps |
There was a problem hiding this comment.
Remove this comment cause it has nothing to do with triple.
| bidiStream := &BidiStreamForClient{err: initErr} | ||
| res := NewResponse(pingv1.CumSumResponse{}) | ||
| err := bidiStream.Receive(res) | ||
| //assert.Nil(t, res) |
| t.Parallel() | ||
| initErr := errors.New("client init failure") | ||
| bidiStream := &BidiStreamForClient{err: initErr} | ||
| res := NewResponse(pingv1.CumSumResponse{}) |
| @@ -220,7 +220,7 @@ func (m *codecMap) Names() []string { | |||
|
|
|||
| func errNotProto(message any) error { | |||
| if _, ok := message.(protoiface.MessageV1); ok { | |||
| return fmt.Errorf("%T uses github.com/golang/protobuf, but connect-go only supports google.golang.org/protobuf: see https://go.dev/blog/protobuf-apiv2", message) | |||
| return fmt.Errorf("%T uses github.com/golang/protobuf, but triple-go only supports google.golang.org/protobuf: see https://go.dev/blog/protobuf-apiv2", message) | |||
There was a problem hiding this comment.
use triple not triple-go
Unit testing of the triple protocol is completed