change method WithClientCheck to WithClientNoCheck #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
May 18, 2024
| @@ -531,9 +531,9 @@ func (cliOpts *ClientOptions) init(opts ...ClientOption) error { | |||
|
|
|||
| type ClientOption func(*ClientOptions) | |||
|
|
|||
| func WithClientCheck() ClientOption { | |||
| func WithClientNoCheck() ClientOption { | |||
There was a problem hiding this comment.
与其改名字，还不如传一个 check bool 参数进来
There was a problem hiding this comment.
这套 options 的 api 整体风格差不多就是枚举配置项，传参有点风格不一致
There was a problem hiding this comment.
这套 options 的 api 整体风格差不多就是枚举配置项，传参有点风格不一致
这个接口改动后，关键是会影响外部用户使用，所以我还是建议不要改名字，可以在注释上把函数的含义解释清楚。对外接口，不要轻易改动。
OR
把这个函数标记为 deprecated，重新实现一个新函数 WithClientNoCheck
There was a problem hiding this comment.
是这样的雨哥，这个 API 目前只发布了一个 rc 版本，使用的人非常少，API 还处于一个不太稳定的状态，而且其实 withCheck 方法用不到，因为默认值就是 true， withCheck 也是设置为true，所以我觉得留着没啥意义
FoghostCn
force-pushed
the
client-no-check
branch
from
3413b11
to
c60423c
Compare
…ntNoCheck with Consumer.Check set to false
FoghostCn
force-pushed
the
client-no-check
branch
from
c60423c
to
8c1a19b
Compare
|
AlexStocks
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #2652
since Consumer.Check default value is true, change method WithClientCheck to WithClientNoCheck with Consumer.Check set to false