-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support deserialization of nested generics (Byte/Short) #63
base: master
Are you sure you want to change the base?
Support deserialization of nested generics (Byte/Short) #63
Conversation
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
============================================
- Coverage 27.79% 27.49% -0.30%
+ Complexity 563 553 -10
============================================
Files 93 94 +1
Lines 6487 6411 -76
Branches 1077 1027 -50
============================================
- Hits 1803 1763 -40
+ Misses 4448 4430 -18
+ Partials 236 218 -18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Dubbo Hessian Lite is not ready to continue incorporating new features. Dubbo is migrating the serialization protocol to fastjson2, if there are new functions, please verify on fastjson2. Since there are so many changes to this PR, I'm afraid we won't be able to merge. |
Actually this is a bug fix, I found this bug two years ago, and this bug still exists until today, use dubbo- samples-generic-invocation can reproduce this bug. When the parameter type of the call is
|
After installing hessian-lite SNAPSHOT locally, use DecodeableRpcInvocationTest.java for testing. |
Adaptation on Dubbo side: Comparing apache:3.1...tianshuang:generic_invocation · apache/dubbo · GitHub, all Dubbo tests have passed. |
Support deserialization of nested generics (Byte/Short), such as
List<Byte>
andList<Short>
.