新增了一个 使用 protosubff的demo 并解决了心跳问题 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
并增加 使用protosubff序列化时 心跳出错的临时解决方案
chenyu2016
changed the title
|
DOCKER> [dubbo-samples-generic-impl-provider:2.7.3-SNAPSHOT]: Start container d44d09f5043a |
beiwei30
reviewed
Jul 23, 2019
...samples-protosubff-api/src/main/java/org/dubbo/samples/protosubff/patch/ProtosubffPatch.java
Show resolved
Hide resolved
beiwei30
reviewed
Jul 23, 2019
...osubff-provider/src/main/java/org/dubbo/samples/protosubff/provider/service/UserService.java
Show resolved
Hide resolved
beiwei30
requested changes
Jul 23, 2019
There was a problem hiding this comment.
Hi @chenyu2016, could you pls. thoroughly check all files and revise as I suggest? Thanks.
remove author info
2 tasks
|
will merge and modify. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增了一个 使用 protosubff的demo
并发现了一个心跳出错并导致断开的bug
做个一个临时的修复
在 org.dubbo.samples.protosubff.patch.ProtosubffPatch
描述了产生问题的原因 和临时解决方案